Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor packer and terraform scripts #44

Merged
merged 4 commits into from
Jul 10, 2022
Merged

Refactor packer and terraform scripts #44

merged 4 commits into from
Jul 10, 2022

Conversation

paseaf
Copy link
Owner

@paseaf paseaf commented Jul 7, 2022 •
edited
Loading

Description

This PR will

Testing the PR

terraform apply should work

@paseaf paseaf changed the title Refactor scripts Refactor packer and terraform scripts Jul 7, 2022
paseaf
paseaf commented Jul 7, 2022
View reviewed changes
terraform/README.md

4. Create a `terraform/terraform.tfvars` file with the following content

```bash
project = "<your_GCP_project_ID>"
credentials_file = "gcp.key.json"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have added it as the default value, so removed

terraform/firewall_rules.tf
@@ -0,0 +1,98 @@
resource "google_compute_firewall" "containerssh_allow_all" {
Copy link
Owner Author

@paseaf paseaf Jul 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracted from main.tf.
They are the same firewall rules as previously

terraform/instances.tf
@@ -0,0 +1,118 @@
resource "google_compute_instance" "gateway_vm" {
Copy link
Owner Author

@paseaf paseaf Jul 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracted from main.tf.
They are the same content as previously

terraform/outputs.tf
@@ -0,0 +1,16 @@
output "vm_ip_addresses" {
Copy link
Owner Author

@paseaf paseaf Jul 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks great! :D

@paseaf paseaf self-assigned this Jul 7, 2022
@paseaf paseaf linked an issue Jul 7, 2022 that may be closed by this pull request
Refactor packer and terraform scripts #8
Closed
@paseaf paseaf marked this pull request as ready for review July 7, 2022 18:13
@paseaf paseaf requested a review from bafread July 7, 2022 18:14
@paseaf paseaf added the refactor label Jul 8, 2022
bafread
bafread approved these changes Jul 10, 2022
View reviewed changes
Copy link
Collaborator

@bafread bafread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's it looks better.

Base automatically changed from zl/change-vm-config to main July 10, 2022 16:55
@paseaf paseaf merged commit c879eda into main Jul 10, 2022
@paseaf paseaf deleted the zl/refactor-scripts branch July 10, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bafread bafread bafread approved these changes

Assignees

@paseaf paseaf

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor packer and terraform scripts
2 participants
@paseaf @bafread