Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[-] make sure WithRewrittenSQL() call is optional, fixes #167 #169

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[-] make sure WithRewrittenSQL() call is optional, fixes #167 #169

merged 1 commit into from
Nov 2, 2023

Conversation

pashagolub
Copy link
Owner

No description provided.

@pashagolub pashagolub linked an issue Nov 2, 2023 that may be closed by this pull request
Issues with new NamedArgs mocks #167
Closed
@pashagolub pashagolub self-assigned this Nov 2, 2023
@pashagolub pashagolub added the bug Something isn't working label Nov 2, 2023
FryDay
FryDay approved these changes Nov 2, 2023
View reviewed changes
Copy link

@FryDay FryDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as I expected.

@pashagolub pashagolub merged commit d47eaa0 into master Nov 2, 2023
4 checks passed
@pashagolub pashagolub deleted the 167-fix-queryrewriter branch November 2, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FryDay FryDay FryDay approved these changes

Assignees

@pashagolub pashagolub

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with new NamedArgs mocks
2 participants
@pashagolub @FryDay