-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding DetuningMap, DMM #539
Conversation
I refactored as you suggested. I also made |
I realized that we don't need the DMMs to be added to the pre-defined devices yet and it actually causes issues, so I just removed it from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfeito !
Main changes: e0943d9 Override `optimal_detuning_off` on stored calls (#588) 3e40319 Deprecate legacy serializer + Improve error messages (#585) 9e05982 Adding register_is_from_calibrated_layout and is_calibrated_layout to Device (#586) c08dfa8 Adding dmm config and modulation to sequence (#564) 5270944 Clarify the Conventions in Pulser (#573) 2315989 Give access to all EOM block parameters and allow for phase drift correction (#566) d5ac020 Adding DetuningMap, DMM (#539) f56a19f Remove expired deprecations in pulser-pasqal
In this draft, I have tried to define a DetuningMap, a DMM and the way to define them via Register, Register3D, MappableRegister, RegisterLayout for the DetuningMap, and in Device for the DMM.
I think the easiest way to draw a DetuningMap is via RegDrawer. The fact that I defined DetuningMap in the module dmm, separately from RegDrawer and Register creates a circular import: To define a Register you need a DetuningMap that needs a RegDrawer that needs the register module to finish intializing.
Conclusion: with the current draft, the next step would be to move the DetuningMap to the register module, and -I guess- DMM to the channel module.