Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support version v4.17.3 Jsonschema #625

Merged
merged 17 commits into from
Dec 14, 2023
Merged

Support version v4.17.3 Jsonschema #625

merged 17 commits into from
Dec 14, 2023

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Dec 13, 2023 •
edited
Loading

Using PR #572, restoring jsonschema v4.17.3
I am first checking that a pipeline works with jsonschema=4.17.3, will move it to jsonschema>4.18.0 afterwards
Closes #624

@a-corni a-corni requested a review from HGSilveri December 13, 2023 15:21
@a-corni a-corni changed the title Bump Jsonschema version to v4.17.3 Support version v4.17.3 Jsonschema Dec 13, 2023
@a-corni
Copy link
Collaborator Author

a-corni commented Dec 13, 2023

Moving condition in requirements.txt to jsonschema >= 4.17.3 since it is working for jsonschema == 4.17.3

HGSilveri
HGSilveri reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should probably do an hotfix instead, otherwise the guys will be blocked until we release v0.17. Wdyt?

pulser-core/requirements.txt Show resolved Hide resolved
tests/test_abstract_repr.py Show resolved Hide resolved
pulser-core/pulser/json/abstract_repr/validation.py Outdated Show resolved Hide resolved
@a-corni
Copy link
Collaborator Author

a-corni commented Dec 14, 2023 •
edited
Loading

LGTM but we should probably do an hotfix instead, otherwise the guys will be blocked until we release v0.17. Wdyt?

That's True, I also have someone asking for #616 to be released in a hotfix, should we first merge this PR and make a hotfix with #616 containing them both ?

Edit: I guess we can merge this PR into master first

@HGSilveri
Copy link
Collaborator

That's True, I also have someone asking for #616 to be released in a hotfix, should we first merge this PR and make a hotfix with #616 containing them both ?

Edit: I guess we can merge this PR into master first

I would make a new hotfix/v0.16.1 branch, merge both PRs into it and then merge that to master. Every merge to master expects a bump in the version, so merging separately would normally require two version bumps.

@a-corni a-corni changed the base branch from develop to master December 14, 2023 14:19
@HGSilveri HGSilveri merged commit 104801a into master Dec 14, 2023
8 checks passed
@HGSilveri HGSilveri deleted the jsonschema_v4.17.3 branch December 29, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HGSilveri HGSilveri HGSilveri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request pulser>=0.16.0 to support jsonschema==4.17.3
2 participants
@a-corni @HGSilveri