-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce imports on main tutorials #636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
CI should pass after #637 is merged |
a-corni
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels... Different than the way I used to write 😅 I will try to reduce imports in the next notebooks and python file I will write :)
HGSilveri
added a commit
that referenced
this pull request
Feb 6, 2024
* Bump to version 0.17dev0 * Refactoring `QutipEmulator` class (#602) * Adding Hamiltonian class * fixing type * Modifying docstring * Simplifying refactoring * Simplifying refactoring * Fix test, simplify attributes in QutipEmulator * Restore _eval_times_instruction, def device in ham * delete get_attr * using NoiseModel for config in Hamiltonian * Fixing doc, tests * Move build_operator, add_config to simulation * Fix typing * Bump to v0.17dev1 * Clarify confusion between kraus operators and collapse operators (#616) * Bump version to v0.17dev0 * Delete L0, refactor error message * Delete identity condition, 2nd order approximation * Fixing tests * Fixing test + doc * Create rate attr, deprecate prob attr * Replace prob by rate, err if def of rate and prob * Fixing type * Use dataclasses.fields, run effective noise notebook * Illustrate rate > 1 in notebook * Modifying cell count * Support standalone serialization of `Register` and `RegisterLayout` to the abstract representation + Hashing for coordinate collections (#627) * Implement CoordsCollection superclass to share hash with Register * Incorporating register and layout schemas * Add serialization and deserialization for layout and register * Add new JSON schemas to the MANIFEST * Add extra UTs * Cover both jsonschema versions in CI * Fix legacy jsonschema validation * Test for legacy jsonschema more efficiently * Addressing review comments * FIX: Coordinate matching in `WeightMap.get_qubit_weight_map()` (#631) * Bump version to 0.17dev2 * Explicitly define public symbols for all modules (#630) * Fix pyright import errors * WIP: Attempt to use __all__ * Exposing the appropriate symbols throughout the codebase * Fix typo * Expose relevant submodules * Expose layout classes in pulser.register * [FIX] Restore compatibility with pytest 8.0.0 (#637) * Unrestrict scipy<1.12 (#635) * Bump version to v0.17dev0 * Remove restriction scipy<1.12 * Clip qutip to 4.7.5 * Replace `Register.rotate()` with `Register.rotated()` (#639) * Modify deprecation of total_bottom_detuning to v0.18 (#638) * Reduce imports on main tutorials (#636) * Bump version to 0.17.0 --------- Co-authored-by: a_corni <antoine.cornillot@pasqal.com> Co-authored-by: Antoine Cornillot <61453516+a-corni@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went with only the main tutorials, I think it's overkill to change it everywhere.
Closes #633 .