Block add() on DMM channels #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-corni
approved these changes
Apr 16, 2024
Comment on lines
+1356
to
+1357
| if not isinstance(self.declared_channels[dmm_name], DMM): | ||
| raise ValueError(f"'{dmm_name}' is not the name of a DMM channel.") |
There was a problem hiding this comment.
Daaamn I had not thought about this
soufianekaghad98
pushed a commit
to soufianekaghad98/Pulser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequence.add()on DMM channelsSequence.add_dmm_detuning()on non-DMM channelsI think having one unique way of adding Pulses to DMM and non-DMM channels is preferable but let me know if you think otherwise