Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lightshift coefficients to RydbergEOM #687

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Add lightshift coefficients to RydbergEOM #687

merged 6 commits into from
Jun 5, 2024

Conversation

HGSilveri
Copy link
Collaborator

@HGSilveri HGSilveri commented May 24, 2024 •
edited
Loading

  • Adds blue_shift_coeff and red_shift_coeff to accommodate for each beam's contribution to lightshift
  • Records which beams are switching in a given EOM block to _EOMSettings
  • Supports the new parameters in the abstract repr JSON schema

@HGSilveri HGSilveri requested a review from a-corni May 24, 2024 08:03
@HGSilveri HGSilveri added this to the Pulser v1 milestone May 24, 2024
@HGSilveri HGSilveri self-assigned this May 29, 2024
a-corni
a-corni reviewed Jun 4, 2024
View reviewed changes
pulser-core/pulser/channels/eom.py Outdated Show resolved Hide resolved
pulser-core/pulser/channels/eom.py Outdated Show resolved Hide resolved
pulser-core/pulser/channels/eom.py Show resolved Hide resolved
pulser-core/pulser/channels/eom.py Outdated Show resolved Hide resolved
pulser-core/pulser/sequence/sequence.py Show resolved Hide resolved
HGSilveri
HGSilveri commented Jun 4, 2024
View reviewed changes
Copy link
Collaborator Author

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @a-corni ! I must say I'm a bit confused by some of your comments

pulser-core/pulser/channels/eom.py Show resolved Hide resolved
pulser-core/pulser/channels/eom.py Outdated Show resolved Hide resolved
pulser-core/pulser/channels/eom.py Outdated Show resolved Hide resolved
pulser-core/pulser/channels/eom.py Outdated Show resolved Hide resolved
pulser-core/pulser/sequence/sequence.py Show resolved Hide resolved
@HGSilveri HGSilveri marked this pull request as ready for review June 4, 2024 15:37
a-corni
a-corni approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! Thanks for the modifications

pulser-core/pulser/channels/eom.py Show resolved Hide resolved
@HGSilveri HGSilveri merged commit 3350807 into develop Jun 5, 2024
7 checks passed
@HGSilveri HGSilveri deleted the hs/lightshift-coeffs branch June 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-corni a-corni a-corni approved these changes

Assignees

@HGSilveri HGSilveri

Labels
None yet
Projects
None yet
Milestone
Pulser v1
Development

Successfully merging this pull request may close these issues.
2 participants
@HGSilveri @a-corni