Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in correct_phase_drift behaviour + more robust Pulse comparison + Python 3.12 support #690

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

HGSilveri
Copy link
Collaborator

@HGSilveri HGSilveri commented Jun 6, 2024

  • Corrects two bugs with correct_phase_drift:
    1. The phase shift correction in enable_eom(..., correct_phase_drift=True) was including the fall time before the buffer, while it should have considered just the buffer.
    2. The correction in add_eom_pulse() was changing only the phase of the added pulse while it should have also shifted the phase reference by this amount
  • Defines a custom Pulse.__eq__(): This was needed for the UTs of correct_phase_drift. The custom method introduces a minimal precision when comparing phase values and it is insensitive to the % (2 *np.pi) wrapping.
  • Removes the fall time from the record of the last time a qubit was used. The fall time was added only so that the phase_shifts were drawn after the modulated pulse was over; in hindsight, this was excessive as it prevents two consecutive pulses (with a phase shift between them) to be placed back-to-back even under the no-delay protocol.
  • Supports python 3.12

@HGSilveri HGSilveri requested a review from a-corni June 6, 2024 08:55
@HGSilveri HGSilveri force-pushed the hotfix/phase-drift branch from 51a0cbd to cf45908 Compare June 6, 2024 10:04
@HGSilveri HGSilveri changed the title Fixes in correct_phase_drift behaviour + more robust Pulse comparison Fixes in correct_phase_drift behaviour + more robust Pulse comparison + Python 3.12 support Jun 6, 2024
pulser-core/pulser/pulse.py Show resolved Hide resolved
pulser-core/pulser/pulse.py Show resolved Hide resolved
@HGSilveri HGSilveri merged commit f4b8a1a into master Jun 7, 2024
8 checks passed
@HGSilveri HGSilveri deleted the hotfix/phase-drift branch June 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants