Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add states labels to Channels and SequenceSamples #705

Merged
merged 17 commits into from
Jul 5, 2024
Merged

Add states labels to Channels and SequenceSamples #705

merged 17 commits into from
Jul 5, 2024

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Jul 2, 2024

  • I am associating states to the bases addressed by Channels
  • such that they can be combined to make addressed states in Device and Sequence
  • and they unify the handling of these quantities in hamiltonian.py
    Conventions.rst is also modified to take into account these labels, but I am not sure it actually improves the understanding of the conventions since it introduces a different label for XY.

@a-corni a-corni requested a review from HGSilveri July 2, 2024 10:28
@a-corni
Copy link
Collaborator Author

a-corni commented Jul 2, 2024

Is this good enough ?
image
Otherwise I am ready for review

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I just have a few suggestions :)

pulser-core/pulser/channels/base_channel.py Outdated Show resolved Hide resolved
pulser-core/pulser/channels/base_channel.py Show resolved Hide resolved
pulser-core/pulser/sequence/sequence.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

pulser-core/pulser/channels/base_channel.py Outdated Show resolved Hide resolved
@a-corni a-corni merged commit e16257a into develop Jul 5, 2024
7 checks passed
@a-corni a-corni deleted the states branch July 5, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants