Modifications needed for pulser-diff #711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum, this will conflict heavily with the changes in #710 ... I would say it would be better to merge those first because we'll just have to redo these anyway. Wdyt? |
Sounds reasonable. I just restored some changes I made previously. I leave the requirements for noise rates to be floats and if we see that in some situations, when no averaging is required in pulser-diff and these rates must be differentiable params, the |
vytautas-a
force-pushed
the
va/noise-torch-fix
branch
from
3bf66f6 to
a2c1a1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support torch tensors in noise configuration.