-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defining the new Backend API classes #764
base: develop
Are you sure you want to change the base?
Conversation
) | ||
|
||
if default_evaluation_times != "Full": | ||
eval_times_arr = np.array(default_evaluation_times, dtype=float) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this a np.array
but below you use AbstractArray
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean for interaction_matrix
? I use AbstractArray
because I expect people might want to differentiate against it
""" | ||
pass | ||
|
||
def infer_one_state(self) -> Eigenstate: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we not simply throw an error if the eigenbasis is not predefined? No backend would know how to simulate it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I get what you mean. Do you mean in the case that the eigenstates
don't match one of these sets we would just throw an error right away?
Results
class and makeResult
a subclass of it in backwards compatible wayState
andOperator
ABCsBackendConfig
and definesEmulationConfig
EmulatorBackend
ABCCallback
andObservable
ABCsTo do:
QutipState
to have an exampleQutipOperator