Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to Sequence to estimate delay introduced before adding pulse #773

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Add method to Sequence to estimate delay introduced before adding pulse #773

merged 6 commits into from
Dec 4, 2024

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Dec 3, 2024

Adds the method estimate_add_delay to Sequence.
Has the same signature as the add method.
Takes into account AOM and EOM Pulses (raise a Warning if the Pulse added is not Constant, with amplitude and detuning equal to the rabi_fres and detuning_on of the EOM Block)
Raise a Warning if the duration of the added Pulse exceeds the duration of the Sequence.
Fixes #761

@a-corni a-corni requested a review from HGSilveri December 3, 2024 15:16
@a-corni a-corni self-assigned this Dec 3, 2024
HGSilveri
HGSilveri reviewed Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I only have nits :)

pulser-core/pulser/sequence/_schedule.py Outdated Show resolved Hide resolved
pulser-core/pulser/sequence/_schedule.py Outdated Show resolved Hide resolved
pulser-core/pulser/sequence/sequence.py Outdated Show resolved Hide resolved
pulser-core/pulser/sequence/sequence.py Outdated Show resolved Hide resolved
tests/test_sequence.py Show resolved Hide resolved
tests/test_sequence.py Outdated Show resolved Hide resolved
HGSilveri
HGSilveri approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@a-corni a-corni merged commit 9a32a2b into develop Dec 4, 2024
9 checks passed
@a-corni a-corni deleted the ac/estimate_delay branch December 4, 2024 09:53
@HGSilveri HGSilveri mentioned this pull request Dec 20, 2024
Merged
HGSilveri added a commit that referenced this pull request Dec 20, 2024
@HGSilveri
Release v1.2.0
c986ec1 
**Main changes:**
- Fixes to the amplitude noise implementation (#768)
- Add method to Sequence to estimate delay introduced before adding pulse (#773)
- Deprecate usage of int in QubitIds (#774)
- Update displayed device specs (#763) 
- Upgrade pulser-simulation to qutip 5 (#783)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HGSilveri HGSilveri HGSilveri approved these changes

Assignees

@a-corni a-corni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function to estimate delay needed between two pulses
2 participants
@a-corni @HGSilveri