Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature | Performance] Add circuit module, Merge gates acting on same qubits #14

Merged
merged 13 commits into from
Apr 16, 2024

Conversation

dominikandreasseitz
Copy link
Collaborator

@dominikandreasseitz dominikandreasseitz commented Apr 12, 2024

  • Add circuit module
  • Add logic to group gates and merge their operators together in case they are acting on the same qubits
  • Improve docstrings and general documentation

@dominikandreasseitz dominikandreasseitz marked this pull request as draft April 12, 2024 14:20
@dominikandreasseitz dominikandreasseitz self-assigned this Apr 15, 2024
@dominikandreasseitz dominikandreasseitz marked this pull request as ready for review April 15, 2024 16:28
Copy link
Collaborator

@jpmoutinho jpmoutinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dominikandreasseitz. I think it is worth adding a test for correctness. I would suggest some series of gates including different types of single and multi-qubit gates and asserting equivalent_state with and without merging. Maybe you can make the merging optional with a boolean defaulting to True?

Copy link
Collaborator

@jpmoutinho jpmoutinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As discussed in the call

@dominikandreasseitz dominikandreasseitz changed the title [Performance] Merge gates acting on same qubits [Feature | Performance] Add circuit module, Merge gates acting on same qubits Apr 16, 2024
@dominikandreasseitz dominikandreasseitz merged commit 92490b8 into main Apr 16, 2024
6 checks passed
@dominikandreasseitz dominikandreasseitz deleted the ds/merge_gates branch April 16, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants