[Feature] Readout noise #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
October 17, 2024 11:54
added 3 commits
October 21, 2024 14:11
jpmoutinho
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Hi @chMoussa, from a quick glance, this design looks good to me, not much to say :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding noise readout (issue #285). I am thinking initially Readout would be specified at the level of the circuit. I am though unsure if this is a good idea given the current Qadence interface of Readout. I wonder if it makes sense to add it as a noise protocol but it is not compatible with the other noise signatures we have. What do you think @jpmoutinho @RolandMacDoland ?
I also fixed the equations display in
noise.mdand remove the annoying logging with Hamevo (it was printing too much on qadence's side).