Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Additional features for error mitigation protocols #56
base: main
Are you sure you want to change the base?
[Feature] Additional features for error mitigation protocols #56
Changes from all commits
4c39d33
b0dfcf0
7507b5d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm these variables names are a bit hard to understand. Could you please use more meaningful names or comment what you're doing here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use
npt.NDArray
here, I'd suggest to keep it consistent elsewhere too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that all variables referring to this type are currently using the specified type. Could you clarify which part might be insufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isnt it possible to just get the sub_matrix
redistributed_matrix = conf_matrix[valid_rows, col] or something ?
this one is m3 with increased hamming distance subspace confusion matrix, correct ? I was under the impression it would be a square matrix with both rows and columns matching and subsampled
I dont think partial sum can add to 0.. entries of confusion matrix are positive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be clever to not sample from the whole twirl space, but rather generate as much needed, as that would be scalable. Not sure if this is straightforward here, feel free to ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you should first get the rows surrounding the non zero locations, expand by hamming distance and then call normalized_subspace over these locations