[Feature] Setting digital noise in addition to readout noise in Pyq backend functions sample and expectation #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @chMoussa nice work. I think we might want to simplify and reorganise functionalities so that it makes the logic more understandable. WDYT ?
Co-authored-by: RolandMacDoland <9250798+RolandMacDoland@users.noreply.github.com>
Co-authored-by: RolandMacDoland <9250798+RolandMacDoland@users.noreply.github.com>
There was a problem hiding this comment.
Thanks @chMoussa looks nice but I think there are bits and pieces that might be simplified. Happy to approve once addressed.
RolandMacDoland
approved these changes
Nov 22, 2024
Co-authored-by: RolandMacDoland <9250798+RolandMacDoland@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementing #591 and #599 where digital and readout noise can be set in the converted circuit from
sampleandexpectation, without the user callingset_noisebeforehand.