(PC-17083) fix(Home): fix modules not loading on homepage #3498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-17083
Module loading is triggered by the call of
onEndReached
on the react native Flatlist. It is a current bug of React Native that onEndReached is sometimes only called once because of race conditions between two flatlist behaviors. We do notice that onEndReached is indeed called once when this bug occurs.This pull request transfers the logic inside
onEndReached
toonScroll
, more reliable.Our hypothesis is partly based on these discussions.
The bug was not only on disconnected users, but it was made more visible because of the lack of displayable modules in the batch of modules made available by the first and only
onEndReached
. For geolocated users, about 10 module ere shown so the fact that no more could be loaded was less noticeable.Checklist
I have:
($jira) $type($scope): $summary
.Screenshots