Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide nginx and php version #107

Merged
merged 1 commit into from
Aug 13, 2018
Merged

hide nginx and php version #107

merged 1 commit into from
Aug 13, 2018

Conversation

FF7C7
Copy link
Contributor

@FF7C7 FF7C7 commented Jun 19, 2018

Hello.
First of all I want to tell many thanks for your work!

What you did

What happened

$ curl https://passbolt.local -I -k
HTTP/1.1 404 Not Found
Server: nginx/1.10.3
Date: Tue, 19 Jun 2018 20:59:33 GMT
Content-Type: text/html; charset=UTF-8
Connection: keep-alive
Keep-Alive: timeout=5
X-Powered-By: PHP/7.2.6

What you expected to happen

I expected that the nginx and PHP version will be hidden.

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2018

CLA assistant check
All committers have signed the CLA.

@dlen dlen self-assigned this Jun 20, 2018
@dlen
Copy link
Member

dlen commented Jun 20, 2018

Hi @FF7C7 !!
Thanks for your contribution!!! You are right, we should hide the nginx and php information.
Your PR will be reviewed soon and most likely merged on the next release.

@FF7C7 FF7C7 force-pushed the master branch 2 times, most recently from 3211e9a to a66f73d Compare June 25, 2018 11:25
@dlen dlen merged commit a66f73d into passbolt:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants