Set up local profiles observer once #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeshux
added a commit
that referenced
this pull request
Jan 4, 2025
Partially reverts #1049 by reloading local profiles without, however, cancelling the subscription.
keeshux
added a commit
that referenced
this pull request
Jan 4, 2025
Rather than redoing ProfileManager.observeLocal() altogether: - Keep the existing profiles subscription (localSubscription) - Reload ALL local profiles on NE notifications The reload is "heavy" because each profile save causes a reload of ALL profiles, but it's the most reliable approach and in the end, it only takes 1-2msec. It can be improved later. Partially reverts #1049, because the app did not sync when a VPN configuration was deleted from the OS settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beyond being useless, reloading the repository across app active/inactive may spoil notifications and leave the profiles list out of sync.