This repository has been archived by the owner on Sep 29, 2024. It is now read-only.
Add initial NCP support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And rename to setupEncryption() for ambiguity with SessionKey.
Across hard and soft reset.
- authToken - peerId - cipher Retain across soft resets.
Enough to claim.
keeshux
force-pushed
the
add-ncp-support
branch
from
0149a70 to
e7e0e95
Compare
keeshux
added a commit
that referenced
this pull request
Sep 5, 2018
Breaks with NCP enabled when cipher is not last. Trailing comma was erroneously included in parsed cipher name. Fixes #11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse cipher from PUSH_REPLY when present. Reflects default OpenVPN 2.4 behavior, namely NCP (Negotiable Crypto Parameters).
Also fixes a bug in compression framing not retained after SOFT_RESET.