update review github actions & remove old hardcoded rds connection (#544

) Co-authored-by: Larisa Bucur <larisabucur@192-168-0-147.rdsnet.ro>
passportxyz · Mar 6, 2024 · 5754aaf · 5754aaf
1 parent 85deacc
commit 5754aaf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/.github/workflows/api-ci-review.yml b/.github/workflows/api-ci-review.yml
@@ -1,11 +1,11 @@
 name: Deploy API to Review
 
-# on:
-#   push:
-#     branches: [main]
-
 on:
-  workflow_dispatch: # This triggers the workflow manually
+  push:
+    branches: [main]
+
+# on:
+#   workflow_dispatch: # This triggers the workflow manually
 
 
 jobs:

diff --git a/infra/aws/index.ts b/infra/aws/index.ts
@@ -64,7 +64,6 @@ const pagerDutyIntegrationEndpoint = `${process.env["PAGERDUTY_INTEGRATION_ENDPO
 
 const coreInfraStack = new pulumi.StackReference(`gitcoin/core-infra/${stack}`);
 const RDS_SECRET_ARN = coreInfraStack.getOutput("rdsSecretArn");
-// coreInfraStack.getOutput("MIGRATION_HARDCODED_RDS_SECRET"); //coreInfraStack.getOutput("test_rdsSecretArn");// coreInfraStack.getOutput("rdsSecretArn"); // test_rdsSecretArn
 
 const vpcID = coreInfraStack.getOutput("vpcId");
 const vpcPrivateSubnetIds = coreInfraStack.getOutput("privateSubnetIds");
@@ -122,11 +121,8 @@ const privateSubnetSecurityGroup = new aws.ec2.SecurityGroup(
 );
 
 const scorerDbProxyEndpoint = coreInfraStack.getOutput("rdsProxyEndpoint");
-// coreInfraStack.getOutput("MIGRATION_HARDCODED_DB_ENDPOINT");  // coreInfraStack.getOutput("test_rdsProxyEndpoint"); // coreInfraStack.getOutput("rdsProxyEndpoint"); // test_rdsProxyEndpoint
 const scorerDbProxyEndpointConn = coreInfraStack.getOutput("rdsProxyConnectionUrl");
-// coreInfraStack.getOutput("MIGRATION_HARDCODED_DB_CONN_URL"); // coreInfraStack.getOutput("test_rdsProxyConnectionUrl"); // coreInfraStack.getOutput("rdsProxyConnectionUrl"); // test_rdsProxyConnectionUrl
 const readreplica0ConnectionUrl = coreInfraStack.getOutput("readreplica0ConnectionUrl");
-// coreInfraStack.getOutput("MIGRATION_HARDCODED_DB_CONN_URL_READ"); // coreInfraStack.getOutput("readreplica0ConnectionUrl"); // test_readreplica0ConnectionUrl
 
 //////////////////////////////////////////////////////////////
 // Set up ALB and ECS cluster
@@ -710,7 +706,7 @@ const redashDb = new aws.rds.Instance(
   {
     identifier: "redash-db",
     allocatedStorage: 20,
-    maxAllocatedStorage: 20,
+    maxAllocatedStorage: 30, // maxAllocatedStorage needs to be bigger than allocatedStorage
     engine: "postgres",
     engineVersion: "13.13",
     instanceClass: "db.t3.micro",