Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update review github actions & remove old hardcoded rds connection #544

Merged
merged 1 commit into from
Mar 6, 2024
Merged

update review github actions & remove old hardcoded rds connection #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/api-ci-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Deploy API to Review

# on:
# push:
# branches: [main]

on:
workflow_dispatch: # This triggers the workflow manually
push:
branches: [main]

# on:
# workflow_dispatch: # This triggers the workflow manually


jobs:
Expand Down
6 changes: 1 addition & 5 deletions infra/aws/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ const pagerDutyIntegrationEndpoint = `${process.env["PAGERDUTY_INTEGRATION_ENDPO

const coreInfraStack = new pulumi.StackReference(`gitcoin/core-infra/${stack}`);
const RDS_SECRET_ARN = coreInfraStack.getOutput("rdsSecretArn");
// coreInfraStack.getOutput("MIGRATION_HARDCODED_RDS_SECRET"); //coreInfraStack.getOutput("test_rdsSecretArn");// coreInfraStack.getOutput("rdsSecretArn"); // test_rdsSecretArn

const vpcID = coreInfraStack.getOutput("vpcId");
const vpcPrivateSubnetIds = coreInfraStack.getOutput("privateSubnetIds");
Expand Down Expand Up @@ -122,11 +121,8 @@ const privateSubnetSecurityGroup = new aws.ec2.SecurityGroup(
);

const scorerDbProxyEndpoint = coreInfraStack.getOutput("rdsProxyEndpoint");
// coreInfraStack.getOutput("MIGRATION_HARDCODED_DB_ENDPOINT"); // coreInfraStack.getOutput("test_rdsProxyEndpoint"); // coreInfraStack.getOutput("rdsProxyEndpoint"); // test_rdsProxyEndpoint
const scorerDbProxyEndpointConn = coreInfraStack.getOutput("rdsProxyConnectionUrl");
// coreInfraStack.getOutput("MIGRATION_HARDCODED_DB_CONN_URL"); // coreInfraStack.getOutput("test_rdsProxyConnectionUrl"); // coreInfraStack.getOutput("rdsProxyConnectionUrl"); // test_rdsProxyConnectionUrl
const readreplica0ConnectionUrl = coreInfraStack.getOutput("readreplica0ConnectionUrl");
// coreInfraStack.getOutput("MIGRATION_HARDCODED_DB_CONN_URL_READ"); // coreInfraStack.getOutput("readreplica0ConnectionUrl"); // test_readreplica0ConnectionUrl

//////////////////////////////////////////////////////////////
// Set up ALB and ECS cluster
Expand Down Expand Up @@ -710,7 +706,7 @@ const redashDb = new aws.rds.Instance(
{
identifier: "redash-db",
allocatedStorage: 20,
maxAllocatedStorage: 20,
maxAllocatedStorage: 30, // maxAllocatedStorage needs to be bigger than allocatedStorage
engine: "postgres",
engineVersion: "13.13",
instanceClass: "db.t3.micro",
Expand Down
Loading