Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update data dump jobs (use read replica & set batch size) #579

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

larisa17
Copy link
Collaborator

@larisa17 larisa17 commented Apr 23, 2024

Those changes were (partially) made manually in AWS . This fixes passportxyz/passport#2427

@larisa17 larisa17 requested review from nutrina and lucianHymer April 23, 2024 20:14
infra/aws/index.ts Outdated Show resolved Hide resolved
infra/aws/index.ts Outdated Show resolved Hide resolved
infra/aws/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@nutrina nutrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.
There are duplicate specifications for batch-size, and some more minor things ...

@larisa17 larisa17 requested a review from nutrina April 26, 2024 07:12
@larisa17 larisa17 dismissed nutrina’s stale review April 26, 2024 16:25

Requested changes were implemented

@larisa17 larisa17 merged commit c1d5306 into main Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make data dump jobs use read replica
2 participants