Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): adding models and admin for address lists #612

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

lucianHymer
Copy link
Collaborator

api/registry/models.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@nutrina nutrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment

@nutrina
Copy link
Collaborator

nutrina commented Jun 11, 2024

In addition to my comment, I am wondering if we should validate the uploaded file for the usual errors: spaces before or at the end of the eth address, etc ...
Maybe we should trim the whitespace from the values?

@lucianHymer lucianHymer marked this pull request as ready for review June 12, 2024 16:01
@lucianHymer lucianHymer merged commit 8cc7faf into main Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AllowList Score Weight Assignment and Uploading Address List
2 participants