-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): adding multiple models to the passport analysis endpoint #631
Merged
tim-schultz
merged 14 commits into
main
from
2459--integrate-zksync-nft-op-arb-and-polygon-scoring-models-into-api-analysis-endpoint-with-30-day-cache-and-single-model-query-restriction-3
Jul 10, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e8a2bc3
to
7b70ab3
Compare
nutrina
added a commit
that referenced
this pull request
Jul 12, 2024
* Revert "feat(api): adding multiple models to the passport analysis endpoint (#631)" This reverts commit 3736df9. * Revert "2459 integrate zksync nft op arb and polygon scoring models into api analysis endpoint with 30 day cache and single model query restriction 2 (#630)" This reverts commit b134116. * Revert "draft: implementation of analysis endpoint o pull from multiple models (#629)" This reverts commit 2acaa00. --------- Co-authored-by: Gerald Iakobinyi-Pich <gerald@gitcoin.co>
nutrina
added a commit
that referenced
this pull request
Jul 16, 2024
…631) * feat: uncommented tests code + attempting to fix failing tests * fix(api): reorder imports * comment out test * disable SSL * force port 80 * test with requests library * fix(api): using standard requests library * test fix * fix test * fix import order * multiple model types * fix tests * chore: test updated model endpoint and pull lambda endpoints from env * chore: update remaining tests --------- Co-authored-by: Lucian Hymer <lucian@gitcoin.co> Co-authored-by: schultztimothy <schultz.timothy52@gmail.com>
nutrina
added a commit
that referenced
this pull request
Jul 16, 2024
#635) * feat: WIP - reading results from multiple models asynchronuosly using aiohttp * feat(api): adding multiple models to the passport analysis endpoint (#631) * feat: uncommented tests code + attempting to fix failing tests * fix(api): reorder imports * comment out test * disable SSL * force port 80 * test with requests library * fix(api): using standard requests library * test fix * fix test * fix import order * multiple model types * fix tests * chore: test updated model endpoint and pull lambda endpoints from env * chore: update remaining tests --------- Co-authored-by: Lucian Hymer <lucian@gitcoin.co> Co-authored-by: schultztimothy <schultz.timothy52@gmail.com> * feat: implementing the async version for the GET /analysis/{address} handler * fix: failing tests * fix: import order matters in lambda * feat: updating workflows --------- Co-authored-by: Lucian Hymer <lucian@gitcoin.co> Co-authored-by: schultztimothy <schultz.timothy52@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: passportxyz/passport#2459