Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra Week: Rework and Modularize Workflows for Passport Repos - passport-scroll-badge-service #2629

Assignees

Comments

@erichfi
Copy link
Contributor

erichfi commented Jun 25, 2024

User Story:
As a devops engineer, I want to rework and modularize the workflows for the passport repositories, so that I can ensure efficient and maintainable CI/CD processes.

Acceptance Criteria:
GIVEN the modularized workflows,
WHEN they are set up,
THEN they should cover the following tasks efficiently and maintainably:

  • Dockerize Workflows for Review, Staging, and Production
  • Deploy App Workflows
  • Deploy IAM Workflows
  • CI Workflow
  • Release & Deploy Workflow
  • Verify On-Chain State

Tech Details:

  • Implement and modularize the following workflows based on detailed documentation:
    • dockerize-review.yml, dockerize-staging.yml, and dockerize-production.yml
    • deploy-app-review.yml, deploy-app-staging.yml, and deploy-app-production.yml
    • deploy-iam-review.yml, deploy-iam-staging.yml, and deploy-iam-production.yml
    • ci.yml
    • release-and-deploy.yml
    • verify-onchain-state.yml
  • Ensure each workflow runs the necessary test suites and checks for inconsistencies in the on-chain state.

Open Questions:

  • Are there specific test suites that need to be run for each environment?

Notes/Assumptions:

@erichfi erichfi added this to Passport Jun 25, 2024
@erichfi erichfi converted this from a draft issue Jun 25, 2024
@nutrina
Copy link
Collaborator

nutrina commented Jul 1, 2024

Prerequisites

  • repos are moved to passportxyz org

Tech notes

  • drop usage of env vars & secrets managed in GH, pull them directly from 1P instead
  • for private repos we shall keep the pattern as in the passport-scroll-badge-service repo (no pause steps)
  • for the public repo we should keep the release workflow as we have in the passport repo with the pause steps to confirm:
    • staging has been tested
    • db changes have been applied
    • pulumi preview

@nutrina
Copy link
Collaborator

nutrina commented Jul 1, 2024

@erichfi we should split this up, make 1 task for each repo:

  1. passport-scroll-badge-service 2 points
  2. passport-data-science 2 points
  3. passport 3 points
  4. identity-staking-app 3 points
  5. passport-scorer 3 points

@Jkd-eth Jkd-eth changed the title Rework and Modularize Workflows for Passport Repos Infra Week: Rework and Modularize Workflows for Passport Repos Jul 9, 2024
@Jkd-eth Jkd-eth changed the title Infra Week: Rework and Modularize Workflows for Passport Repos Infra Week: Rework and Modularize Workflows for Passport Repos - passport-scroll-badge-service Jul 9, 2024
@nutrina
Copy link
Collaborator

nutrina commented Jul 19, 2024

This is in a good spot ( https://github.com/passportxyz/passport-scroll-badge-service/actions/runs/10008414868 ), what is still open:

  • merge in the lates fixed from the gitcoinco org
  • test the release to production
  • test the release workflow

Picking up #2682 first to test that the same concepts / actions can be reused on other repos as well.

@nutrina nutrina moved this from Blocked to In Progress (WIP) in Passport Jul 23, 2024
@nutrina nutrina moved this from In Progress (WIP) to Code Complete in Passport Jul 24, 2024
@nutrina nutrina moved this from Code Complete to Product/UX Review in Passport Jul 24, 2024
@nutrina nutrina moved this from Product/UX Review to In Progress (WIP) in Passport Jul 24, 2024
@nutrina nutrina moved this from In Progress (WIP) to Blocked in Passport Jul 24, 2024
@nutrina nutrina moved this from Blocked to Product/UX Review in Passport Jul 24, 2024
@erichfi erichfi moved this from Product/UX Review to Ready to Deploy in Passport Jul 24, 2024
@erichfi erichfi moved this from Ready to Deploy to Done in Passport Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment