Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] improvement: use jaspr to render html page #76

Merged
merged 10 commits into from
Dec 12, 2024
Merged

[WIP] improvement: use jaspr to render html page #76

merged 10 commits into from
Dec 12, 2024

Conversation

schultek
Copy link
Contributor

@passsy What do you think?

Just the proof of concept for now, can be improved.

@passsy
Copy link
Owner

passsy commented Nov 22, 2024

Awesome! I was a bit worried that rendering would take too long. I measured 35ms. That's a tax I'm willing to pay!

I already feel more confident writing logic in Jaspr vs plain HTML/CSS. I'm happy to take it over from here ✌️

@schultek
Copy link
Contributor Author

schultek commented Nov 22, 2024 •
edited
Loading

Very cool.

I'm setting up the client logic right now, give me another day then you can take over 😊

@schultek
Copy link
Contributor Author

Now its fully migrated, Jaspr renders both server-side (the html generation) and client side (the interactivity).

To keep the setup simple, I added a tooling script that compiles the client-side code to js and places it in the script.js.dart file. So whenever the client-side code is modified, run dart run tool/compile_js.dart.

For now I just mirrored the exact design and functionality of the existing website, but I'm happy to help with improving this as a follow up if you want.

Kilian Schulte added 2 commits November 25, 2024 19:46
split into server and client apps
ee7d928
Merge branch 'jaspr-timeline' of https://github.com/schultek/spot int…
128bd42 
…o jaspr-timeline

# Conflicts:
#	lib/src/timeline/html/print_html.dart
#	lib/src/timeline/html/web/timeline_app.dart
@schultek schultek marked this pull request as ready for review November 25, 2024 18:51
@schultek schultek requested a review from passsy November 25, 2024 18:51
@passsy passsy merged commit 985c14d into passsy:main Dec 12, 2024
6 checks passed
@passsy
Copy link
Owner

passsy commented Dec 12, 2024

Thanks so much @schultek for your efforts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passsy passsy Awaiting requested review from passsy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schultek @passsy