Enable C# 11 and embed base64 encoded certificates as UTF-8 data #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh, CI doesn't like C# 11. I'll look into this a bit later. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 75.02% 75.23% +0.20%
==========================================
Files 95 95
Lines 2751 2782 +31
Branches 457 458 +1
==========================================
+ Hits 2064 2093 +29
+ Misses 575 574 -1
- Partials 112 115 +3
|
iamcarbon
changed the title
|
future note: We should also consider cross-targeting and testing against net8.0 after Preview 7 or RC1. This will also provide us with the latest System.Text.Json source generation improvements. |
|
@abergs Ready for review. |
abergs
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is a bit faster to parse UTF-8 data directly than convert from UTF-16.
NOTE, this uses the built-in support for static data initialization. Accessing ROOT_CERT is non-allocating and refers directly to the data.
This PR also simplifies a check using C# 11 list patterns.