Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align MSBuild properties across all projects #437

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Align MSBuild properties across all projects #437

merged 6 commits into from
Nov 10, 2023

Conversation

joegoldman2
Copy link
Contributor

  • Set TargetFrameworks to $(SupportedTargetFrameworks)
  • Align LanguageVersion to 11
  • Set ImplicitUsings to enable in root Directory.Build.props
  • Miscellaneous cleanup

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (15263ca) 77.50% compared to head (2ccd1af) 77.50%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   77.50%   77.50%           
=======================================
  Files          98       98           
  Lines        2716     2716           
  Branches      445      445           
=======================================
  Hits         2105     2105           
  Misses        492      492           
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iamcarbon iamcarbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we Add disable to main Fido2.csproj for now. I prefer these to remain explicit on that project and defer a decision on whether we should enable.

Src/Fido2/Fido2.csproj Show resolved Hide resolved
@iamcarbon
Copy link
Contributor

Aside from disabling implicating using on Fido2.csproj, everything else looks good to me.

@aseigler aseigler requested a review from iamcarbon October 23, 2023 15:02
Copy link
Contributor

@iamcarbon iamcarbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abergs abergs merged commit ebfd75d into passwordless-lib:master Nov 10, 2023
7 checks passed
@joegoldman2 joegoldman2 deleted the feat/align-csproj branch November 10, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants