-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align MSBuild properties across all projects #437
Align MSBuild properties across all projects #437
Conversation
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
=======================================
Coverage 77.50% 77.50%
=======================================
Files 98 98
Lines 2716 2716
Branches 445 445
=======================================
Hits 2105 2105
Misses 492 492
Partials 119 119 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May we Add disable to main Fido2.csproj for now. I prefer these to remain explicit on that project and defer a decision on whether we should enable.
Aside from disabling implicating using on Fido2.csproj, everything else looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TargetFrameworks
to$(SupportedTargetFrameworks)
LanguageVersion
to 11ImplicitUsings
toenable
in rootDirectory.Build.props