Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add credProtect extension to Fido2.Models #448

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

dbeinder
Copy link
Contributor

@dbeinder dbeinder commented Oct 14, 2023

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (15263ca) 77.50% compared to head (50f3a7e) 77.41%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   77.50%   77.41%   -0.10%     
==========================================
  Files          98       98              
  Lines        2716     2727      +11     
  Branches      445      448       +3     
==========================================
+ Hits         2105     2111       +6     
- Misses        492      496       +4     
- Partials      119      120       +1     
Files Coverage Δ
...s/Objects/AuthenticationExtensionsClientOutputs.cs 77.77% <0.00%> (-9.73%) ⬇️
...ls/Objects/AuthenticationExtensionsClientInputs.cs 10.00% <0.00%> (-2.50%) ⬇️
Src/Fido2.Models/Converters/FidoEnumConverter.cs 71.42% <66.66%> (+4.76%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aseigler aseigler self-requested a review October 23, 2023 14:31
@jonashendrickx
Copy link
Contributor

Confirmed input to be working.

Copy link
Collaborator

@aseigler aseigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abergs abergs merged commit 67eec54 into passwordless-lib:master Jan 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants