Rename clientDataJson to clientDataJSON

[joegoldman2]

Fixes #338.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (934abe4) 77.52% compared to head (da68730) 77.52%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #450   +/-   ##
=======================================
  Coverage   77.52%   77.52%           
=======================================
  Files          98       98           
  Lines        2714     2714           
  Branches      445      445           
=======================================
  Hits         2104     2104           
  Misses        491      491           
  Partials      119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aseigler]

This is one of those things that has been inconsistent from day one. Should we take the call to rename all instances of clientDataJson to clientDataJSON and not just these two?

[joegoldman2]

This is one of those things that has been inconsistent from day one. Should we take the call to rename all instances of clientDataJson to clientDataJSON and not just these two?

I was not sure if we want to use clientDataJSON with uppercase also in the c#. If you are ok with this, I can rename the property also in the c# contract.

[aseigler]

This is one of those things that has been inconsistent from day one. Should we take the call to rename all instances of clientDataJson to clientDataJSON and not just these two?

I was not sure if we want to use clientDataJSON with uppercase also in the c#. If you are ok with this, I can rename the property also in the c# contract.

@abergs , @iamcarbon , opinions?

[iamcarbon]

My personal preference would be to use clientDataJSON during JSON serialization, and rename all the C# properties to "ClientDataJson" to remain consistent with .NET conventions.

[abergs]

For serialization/deserialization it should definitely be named clientDataJSON. That is what is used in the spec.

I would have tried to make the point on keeping JSON in .NET to make it less error-prone, but we rely on [JsonPropertyName] for many other fields, so that point is mute.

Go ahead and rename it to Json in .net @joegoldman2.

[abergs]

As discussed

[abergs]

Thanks, looks good!