Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIDO Conformance Tools v1.7.15 fixes #456

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Commits on Oct 24, 2023

  1. FIDO Conformance Tools v1.7.15 fixes

    TrustAnchor.cs : 32
    Server-ServerAuthenticatorAttestationResponse-Resp-5 Test server processing "packed" FULL attestation
    F-10 Send ServerAuthenticatorAttestationResponse with FULL "packed" attestation, with attStmt.x5c containing full chain, and check that server returns an error
    https://datatracker.ietf.org/doc/html/rfc5280#section-6.1
    
    AuthenticatorAttestationRawResponse.cs : 18
    Server-ServerAuthenticatorAttestationResponse-Resp-1 Test server processing ServerAuthenticatorAttestationResponse structure
    F-4 Send ServerAuthenticatorAttestationResponse that is missing "type" field and check that server returns an error
    
    CredentialCreateOptions.cs : 96
    Server-ServerAuthenticatorAttestationResponse-Resp-4 Test server support of the authentication algorithms
    P-8 Send a valid ServerAuthenticatorAttestationResponse with SELF "packed" attestation, for "ALG_SIGN_RSASSA_PKCSV15_SHA1_RAW" aka "RS1" algorithm, and check that server succeeds
    Server-ServerAuthenticatorAttestationResponse-Resp-9 Test server processing "tpm" attestation
    P-2 Send a valid ServerAuthenticatorAttestationResponse with "tpm" attestation for SHA-1, and check that server succeeds
    
    CredentialCreateOptions.cs  : 210
    Server-ServerPublicKeyCredentialCreationOptions-Req-1 Test server generating ServerPublicKeyCredentialCreationOptionsRequest
    P-1 Get ServerPublicKeyCredentialCreationOptionsResponse, and check that: (a) response MUST contain ...
    
    AuthenticationExtensionsClientInputs.cs : 23 public string AppID { private get; set; }
    Server-ServerPublicKeyCredentialGetOptionsResponse-Req-1 Test server generating ServerPublicKeyCredentialGetOptionsResponse
    P-1 Get ServerPublicKeyCredentialGetOptionsResponse, and check that: (a) response MUST contain ...
    
    AuthenticationExtensionsClientInputs.cs :  44 public bool? UserVerificationMethod { private get; set; }
    Server-ServerPublicKeyCredentialGetOptionsResponse-Req-1 Test server generating ServerPublicKeyCredentialGetOptionsResponse
    P-1 Get ServerPublicKeyCredentialGetOptionsResponse, and check that: (a) response MUST contain ...
    
    AuthenticatorAssertionResponse.cs : 128
    Server-ServerAuthenticatorAssertionResponse-Resp-3
    P4,P6,P7
    
    CryptoUtils.cs 64 (trustpath length 1 with exact match in attestation root certs)
    Server-ServerAuthenticatorAttestationResponse-Resp-5 Test server processing "packed" FULL attestation
    P-3 Send a valid ServerAuthenticatorAttestationResponse with FULL "packed" attestation that contains batch certificate, that is simply self referenced in the metadata, and check that server succeeds
    
    CryptoUtils.cs 105 - X509RevocationMode.Online makes conformance sad
    Server-ServerAuthenticatorAttestationResponse-Resp-9 Test server processing "tpm" attestation
    P-1 Send a valid ServerAuthenticatorAttestationResponse with "tpm" attestation for SHA-256, and check that server succeeds‣
    P-2 Send a valid ServerAuthenticatorAttestationResponse with "tpm" attestation for SHA-1, and check that server succeeds‣
    P-3 Send a valid ServerAuthenticatorAttestationResponse with "tpm" attestation pubArea.nameAlg is not matching algorithm used for generate attested.name, and check that server succeeds
    
    TestController.cs tojson -> serialize
    serialization error
    Gabor Mihaly authored and Gabor Mihaly committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    944f168 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Json serialization fix

    Json serialization fix. (Object type vs ToJson())
    Gabor Mihaly authored and Gabor Mihaly committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b700a2f View commit details
    Browse the repository at this point in the history
  2. Unit test fix

    Gabor Mihaly authored and Gabor Mihaly committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    2b2382b View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. tokenbindig, AppId, UVP

    Back to 100% conformance.
    TokenBinding logic readded.
    AppId: prevent serialization in a nicer way.
    UV flags are verified differently for conformance testing, otherwise as described in the RFC.
    googyi committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    13d2a3c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3432820 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3113ee8 View commit details
    Browse the repository at this point in the history
  4. fix azure pipeline

    fix azure pipeline's whitespace error + removing unused using
    googyi committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    c55c799 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Improve trustanchor test coverage

    Improve trustanchor test coverage based on codecov report
    googyi committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    7534243 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    40a68e7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfaa1f9 View commit details
    Browse the repository at this point in the history