Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidying #500

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Tidying #500

merged 4 commits into from
Feb 16, 2024

Conversation

iamcarbon
Copy link
Contributor

This PR updates a couple more classes to use primary constructors and collection expressions.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (0a9886d) 73.94% compared to head (ee79c98) 73.97%.

Files Patch % Lines
Src/Fido2/Metadata/FileSystemMetadataRepository.cs 0.00% 8 Missing ⚠️
Src/Fido2.Models/CredentialCreateOptions.cs 81.25% 3 Missing ⚠️
Src/Fido2.Models/Fido2Configuration.cs 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   73.94%   73.97%   +0.03%     
==========================================
  Files          99       99              
  Lines        2698     2671      -27     
  Branches      461      461              
==========================================
- Hits         1995     1976      -19     
+ Misses        598      590       -8     
  Partials      105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abergs abergs merged commit 57b8652 into passwordless-lib:master Feb 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants