Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Test folder to Tests/Fido2.Tests #549

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

joegoldman2
Copy link
Contributor

It is quite confusing to have two test folders at the root of the repo. This PR moves Test folder to Tests/Fido2.Tests.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (0ea57fd) to head (28280ca).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #549   +/-   ##
=======================================
  Coverage   74.62%   74.62%           
=======================================
  Files         101      101           
  Lines        2719     2719           
  Branches      464      464           
=======================================
  Hits         2029     2029           
  Misses        581      581           
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this makes fully sense.

@abergs
Copy link
Collaborator

abergs commented Oct 18, 2024

@joegoldman2 Could you adress the conflicts and we can get this merged?

@abergs abergs merged commit 455f428 into passwordless-lib:master Oct 18, 2024
11 checks passed
@joegoldman2 joegoldman2 deleted the move-tests branch October 18, 2024 16:42
@abergs abergs added this to the Version 4 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants