Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanup #558

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Various cleanup #558

merged 2 commits into from
Oct 28, 2024

Conversation

joegoldman2
Copy link
Contributor

Mainly:

  • Remove trailing spaces
  • Add missing carriage return at the end of some files
  • Re-encode some files to comply with the encoding defined in the .editorconfig

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (455f428) to head (88586cc).

Files with missing lines Patch % Lines
Src/Fido2/AttestationFormat/AttestationVerifier.cs 0.00% 1 Missing and 1 partial ⚠️
...ido2/Objects/DevicePublicKeyAuthenticatorOutput.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   74.62%   74.62%           
=======================================
  Files         101      101           
  Lines        2719     2719           
  Branches      464      464           
=======================================
  Hits         2029     2029           
  Misses        581      581           
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joegoldman2
Copy link
Contributor Author

@abergs this PR is ready to be reviewed.

@iamcarbon
Copy link
Contributor

Everything looks good to me.

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@abergs abergs merged commit 72f5a36 into passwordless-lib:master Oct 28, 2024
11 checks passed
@joegoldman2 joegoldman2 deleted the cleanup branch October 28, 2024 15:21
@abergs abergs added this to the Version 4 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants