Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthenticatorSelection Default to discourage UV #564

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

abergs
Copy link
Collaborator

@abergs abergs commented Oct 29, 2024

This PR modifies the default AuthenticatorSelection configuration to discourage User Verification (UV). This change aims to improve the overall user experience for most applications where UV isn't a critical security requirement.

Rationale

  • Most applications don't require User Verification during signing operations
  • Disabling UV by default reduces friction in the authentication flow
  • Applications that need UV can still explicitly enable it

Discussion Points

I'd appreciate community feedback on this change, particularly regarding:

  • Security implications
  • User experience trade-offs
  • Specific use cases where this might be problematic

CC: @aseigler @iamcarbon @joegoldman2

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.72%. Comparing base (e687bc6) to head (fa9a488).

Files with missing lines Patch % Lines
Src/Fido2.Models/CredentialCreateOptions.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files         103      103           
  Lines        2730     2730           
  Branches      464      464           
=======================================
  Hits         2040     2040           
  Misses        581      581           
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abergs abergs added this to the Version 4 milestone Nov 5, 2024
@abergs abergs merged commit 94f6071 into master Nov 12, 2024
11 checks passed
@abergs abergs deleted the uv-discourage branch November 12, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants