Drop support for device public key (dpk) #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aseigler Please let me know if you have any blocking thoughts. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 74.73% 76.96% +2.22%
==========================================
Files 103 100 -3
Lines 2731 2613 -118
Branches 464 441 -23
==========================================
- Hits 2041 2011 -30
+ Misses 581 496 -85
+ Partials 109 106 -3 ☔ View full report in Codecov by Sentry. |
|
It's disappointing that this didn't make it, but that's the way it goes. Looks reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #566. This PR removes support for device public keys as they have been dropped from the L3 spec.
It's a bit heartbreking to remove this much feature code, but if dpk's make it back as supplemental keys the implementation would probably look quite different.