Move KeyTypeParameter validation from CredentialPublicKey.Verify() into constructors #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to constructors Add test for invalid COSE key types Add support for OKP certificates for CredentialPublicKey and test for same Fix two packed tests that erroneously used "Reserved" key type instead of P256.
…to constructors Add test for invalid COSE key types Add support for OKP certificates for CredentialPublicKey and test for same Fix two packed tests that erroneously used "Reserved" key type instead of P256.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
==========================================
- Coverage 76.96% 76.92% -0.04%
==========================================
Files 100 100
Lines 2613 2626 +13
Branches 441 441
==========================================
+ Hits 2011 2020 +9
- Misses 496 498 +2
- Partials 106 108 +2 ☔ View full report in Codecov by Sentry. |
|
Seems CodeCov is mostly complaining about not covering the throw's which I think is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for invalid COSE key types
Add support for OKP certificates for CredentialPublicKey and test for same
Fix two packed tests that erroneously used "Reserved" key type instead of P256
Closes #552