Skip to content

Commit

Permalink
sapui5: code style fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
passy committed Jul 3, 2013
1 parent e7fbe33 commit 9d27117
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 45 deletions.
4 changes: 2 additions & 2 deletions labs/architecture-examples/sapui5/js/todo/TodoPersistency.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
this.name = aName;
};

todo.TodoPersistency.prototype = function () {
todo.TodoPersistency.prototype = (function () {
var storage = window.localStorage;

return {
Expand All @@ -29,5 +29,5 @@
return !(this.get());
}
};
}();
}());
})();
86 changes: 43 additions & 43 deletions labs/architecture-examples/sapui5/js/todo/formatters.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,55 +10,55 @@
jQuery.sap.declare('todo.formatters');

todo.formatters = {
// Returns whether all todos are completed
allCompletedTodosFormatter: function (aTodos) {
return !(aTodos.some(function (element, index, array) {
return element.done === false;
}));
},
// Returns whether all todos are completed
allCompletedTodosFormatter: function (aTodos) {
return !(aTodos.some(function (element, index, array) {
return element.done === false;
}));
},

// Converts booleans to strings
booleanToStringFormatter: function (value) {
if (value === true) {
return 'true';
}
return 'false';
},
// Converts booleans to strings
booleanToStringFormatter: function (value) {
if (value === true) {
return 'true';
}
return 'false';
},

// Counts the number of closed todos
completedTodoCountFormatter: function (aTodos) {
var numberOfCompletedItems = 0;
aTodos.forEach(function (todo) {
if (todo.done === true) {
numberOfCompletedItems++;
}
});
// Counts the number of closed todos
completedTodoCountFormatter: function (aTodos) {
var numberOfCompletedItems = 0;
aTodos.forEach(function (todo) {
if (todo.done === true) {
numberOfCompletedItems++;
}
});

return 'Clear completed (' + numberOfCompletedItems + ')';
},
return 'Clear completed (' + numberOfCompletedItems + ')';
},

// Returns whether a completed todo is available
hasCompletedTodosFormatter: function (aTodos) {
return aTodos.some(function (element, index, array) {
return element.done === true;
});
},
// Returns whether a completed todo is available
hasCompletedTodosFormatter: function (aTodos) {
return aTodos.some(function (element, index, array) {
return element.done === true;
});
},

// Returns whether a an array has elements
isArrayNonEmptyFormatter: function (aTodos) {
return aTodos.length > 0;
},
// Returns whether a an array has elements
isArrayNonEmptyFormatter: function (aTodos) {
return aTodos.length > 0;
},

// Counts the number of open todos
openTodoCountFormatter: function (aTodos) {
var numberOfOpenItems = 0;
aTodos.forEach(function (todo) {
if (todo.done === false) {
numberOfOpenItems++;
}
});
// Counts the number of open todos
openTodoCountFormatter: function (aTodos) {
var numberOfOpenItems = 0;
aTodos.forEach(function (todo) {
if (todo.done === false) {
numberOfOpenItems++;
}
});

return numberOfOpenItems === 1 ? '1 item left' : numberOfOpenItems + ' items left';
}
return numberOfOpenItems === 1 ? '1 item left' : numberOfOpenItems + ' items left';
}
};
})();

0 comments on commit 9d27117

Please sign in to comment.