Spec: Wrap context IDs in a "pre-specified report parameters" object #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@linnan-github @arichiv, could you PTAL? Thanks! Split this off of #123 per discussion. |
arichiv
approved these changes
May 2, 2024
linnan-github
approved these changes
May 2, 2024
This new struct will be used for the filtering ID handling in a follow-up spec change. This PR also factors out the determination of whether a report should be sent deterministically into its own algorithm to simplify the future change. This PR should be a no-op.
alexmturner
force-pushed
the
split_off_params_changes
branch
from
36da89a to
d3f4c99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new struct will be used for the filtering ID handling in a follow-up spec change. This PR also factors out the determination of whether a report should be sent deterministically into its own algorithm to simplify the future change. This PR should be a no-op.
Preview | Diff