Correct history for issued_to + fix changelog for Estimates
#73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcothenet
commented
Jul 29, 2022
Comment on lines
+19
to
+25
| - Renames the `issuedTo` parameter for `orders` to `issued_to`. | ||
|
|
||
| ## [1.23.0] - 2022-06-03 | ||
|
|
||
| ### Added | ||
|
|
||
| - Adds support for the `issued_to` parameter on `orders`, to add support for creating and placing orders on behalf of another party. | ||
| - Adds support for the `issuedTo` parameter on `orders`, to add support for creating and placing orders on behalf of another party. |
There was a problem hiding this comment.
@holtbp fixing the timeline here.
pcothenet
commented
Jul 29, 2022
src/api/OrdersApi.js
Outdated
Comment on lines
114
to
110
| if (id === undefined || id === null) { | ||
| if (_id === undefined || _id === null) { |
There was a problem hiding this comment.
I don't understand this change, this seems incorrect.
pcothenet
commented
Jul 29, 2022
src/api/OrdersApi.js
Outdated
| const _placeOrderRequest = PlaceOrderRequest.constructFromObject( | ||
| opts, | ||
| new CreateOrderRequest() | ||
| ); | ||
| let postBody = _placeOrderRequest; | ||
| let postBody = opts['placeOrderRequest']; |
There was a problem hiding this comment.
Also strange, investigating.
pcothenet
commented
Jul 29, 2022
| import V1OrdersIssuedTo from './V1OrdersIssuedTo'; | ||
| import OrderIssuedTo from './OrderIssuedTo'; |
There was a problem hiding this comment.
Avoids introducing this weird solo V1 file (this change is due to using a reusable schema for order_issued_to in swagger).
pcothenet
commented
Jul 29, 2022
Comment on lines
+17
to
+25
| ### Breaking | ||
|
|
||
| - Renames the `issuedTo` parameter for `orders` to `issued_to`. | ||
|
|
||
| ## [1.23.0] - 2022-06-03 | ||
|
|
||
| ### Added | ||
|
|
||
| - Adds support for the `issued_to` parameter on `orders`, to add support for creating and placing orders on behalf of another party. | ||
| - Adds support for the `issuedTo` parameter on `orders`, to add support for creating and placing orders on behalf of another party. |
There was a problem hiding this comment.
@holtbp I'm rewriting the timeline here.
pcothenet
changed the title
issued_to + fix changelog for Estimates
holtbp
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
issued_toWhy
SDK Release Checklist