Skip to content

Filter projects #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2021
Merged

Filter projects #16

merged 2 commits into from
Feb 17, 2021

Conversation

biglovisa
Copy link
Contributor

What

  • Add country/type filtering for Projects

Why

  • To make it easier to only retrieve the Projects that match your criteria.

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@biglovisa biglovisa self-assigned this Feb 16, 2021
@biglovisa biglovisa added the Needs Review The PR is ready to be reviewed label Feb 16, 2021
@biglovisa biglovisa force-pushed the lovisa/add-test-for-filtering branch from 7f5bcaf to 28585bc Compare February 16, 2021 22:57
@biglovisa biglovisa force-pushed the lovisa/add-test-for-filtering branch from 28585bc to 835ca57 Compare February 16, 2021 23:02
thdaraujo
thdaraujo reviewed Feb 17, 2021
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the filter is getting added to all the endpoints, no?

patch_api/api/estimates_api.py Outdated
@@ -40,6 +40,8 @@ class EstimatesApi(object):
"model",
"make",
"year",
"type",
"country",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 should this here too?
is the generator adding this filter parameter to all the endpoints or just projects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@biglovisa biglovisa requested a review from thdaraujo February 17, 2021 16:39
@biglovisa biglovisa force-pushed the lovisa/add-test-for-filtering branch from e1b6531 to 1915845 Compare February 17, 2021 16:51
@biglovisa biglovisa changed the title Add country/type filtering for Projects Filter projects Feb 17, 2021
thdaraujo
thdaraujo approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@thdaraujo thdaraujo added Ready This PR is ready to ship! and removed Needs Review The PR is ready to be reviewed labels Feb 17, 2021
@biglovisa biglovisa merged commit 2dde633 into main Feb 17, 2021
@biglovisa biglovisa deleted the lovisa/add-test-for-filtering branch February 17, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thdaraujo thdaraujo thdaraujo approved these changes

Assignees

@biglovisa biglovisa

Labels
Ready This PR is ready to ship!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biglovisa @thdaraujo