-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bitcoin estimates and registry_url #26
Conversation
patch_api/api/estimates_api.py
Outdated
from patch_api.exceptions import ( | ||
ApiTypeError, | ||
ApiValueError | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With python, since the beginning, I have been getting a different formatting than Lovisa had.
I'm not completely sure which one is the expected one given the settings. If mine, this might be worth updating once and for all.
@@ -1,13 +0,0 @@ | |||
name: Lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this to merge with the tests instead.
Makefile
Outdated
lint: | ||
pre-commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't used.
lint: | ||
pre-commit | ||
pip install -r test-requirements.txt && \ | ||
black . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing this command and adding to the readme file.
all_params.append("transaction_value_btc_sats") | ||
all_params.append("timestamp") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cruft is a function of the code generator. Would be great to read allowed parameters from the OpenAPI file.
README.md
Outdated
@@ -139,6 +139,10 @@ model = "Corolla" | |||
year = 1995 | |||
patch.estimates.create_mass_estimate(distance_m=distance_m, make=make, model=model, year=year) | |||
|
|||
# Create a bitcoin estimate | |||
transaction_value_btc_sats = 1000; # [Optional] Pass in the transaction value in satoshis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the ;
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
What
Why
SDK Release Checklist