Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitcoin estimates and registry_url #26

Merged
merged 10 commits into from
Jul 14, 2021
Merged

Add bitcoin estimates and registry_url #26

merged 10 commits into from
Jul 14, 2021

Conversation

pcothenet
Copy link
Contributor

@pcothenet pcothenet commented Jul 2, 2021

What

  • Adding bitcoin endpoints
  • Adding registry_url in endpoints

Why

  • Expose new functionalities

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

Comment on lines 21 to 24
from patch_api.exceptions import (
ApiTypeError,
ApiValueError
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With python, since the beginning, I have been getting a different formatting than Lovisa had.

I'm not completely sure which one is the expected one given the settings. If mine, this might be worth updating once and for all.

@pcothenet pcothenet changed the title Add bitcoin and registry_url Add bitcoin estimates and registry_url Jul 2, 2021
@@ -1,13 +0,0 @@
name: Lint
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this to merge with the tests instead.

Makefile Outdated
Comment on lines 7 to 8
lint:
pre-commit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't used.

Comment on lines 7 to +9
lint:
pre-commit
pip install -r test-requirements.txt && \
black .
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing this command and adding to the readme file.

Comment on lines +269 to +270
all_params.append("transaction_value_btc_sats")
all_params.append("timestamp")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cruft is a function of the code generator. Would be great to read allowed parameters from the OpenAPI file.

@pcothenet pcothenet requested a review from bspellacy July 14, 2021 13:50
@pcothenet pcothenet marked this pull request as ready for review July 14, 2021 13:50
@pcothenet pcothenet requested a review from boconnell2 July 14, 2021 13:55
README.md Outdated
@@ -139,6 +139,10 @@ model = "Corolla"
year = 1995
patch.estimates.create_mass_estimate(distance_m=distance_m, make=make, model=model, year=year)

# Create a bitcoin estimate
transaction_value_btc_sats = 1000; # [Optional] Pass in the transaction value in satoshis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the ; here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@pcothenet pcothenet requested a review from bspellacy July 14, 2021 16:36
@pcothenet pcothenet merged commit 0d83381 into main Jul 14, 2021
@pcothenet pcothenet deleted the pc/16 branch July 14, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants