Skip to content

Improve automatic generation #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2021
Merged

Improve automatic generation #32

merged 1 commit into from
Aug 31, 2021

Conversation

pcothenet
Copy link
Contributor

What

Why

  • Make generating new versions of the SDK easier

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

pcothenet
pcothenet commented Aug 31, 2021
View reviewed changes
patch_api/models/__init__.py
Comment on lines +19 to +21
from patch_api.models.create_bitcoin_estimate_request import (
CreateBitcoinEstimateRequest,
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those models were previously ignored by our codegen.

Proposing to stay as close as possible from the standard output of https://github.com/OpenAPITools/openapi-generator and stop ignoring them.

AFAIK, this has no impact.

@pcothenet pcothenet requested a review from kleinjm August 31, 2021 17:17
kleinjm
kleinjm approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@kleinjm kleinjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker but I'd suggest a patch version bump on this one as well for both parity and because it is a change that could break. Now that we have the user agent, we can monitor for issues

@pcothenet pcothenet merged commit 2c24a18 into main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleinjm kleinjm kleinjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcothenet @kleinjm