-
Notifications
You must be signed in to change notification settings - Fork 2
Adds the verifier field to the project response #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,11 +70,11 @@ def test_retrieve_projects(self): | |
self.assertGreater(project.average_price_per_tonne_cents_usd, 0) | ||
self.assertGreater(project.remaining_mass_g, 0) | ||
self.assertEqual(project.standard, None) | ||
self.assertRegex(project.name, r"Test Offset Project") | ||
self.assertIsInstance(project.name, str) | ||
self.assertTrue(project.description) | ||
self.assertEqual(project.country, "US") | ||
self.assertEqual(project.type, "biomass") | ||
self.assertEqual(project.developer, "Patch Sandbox Supplier Test") | ||
self.assertIsInstance(project.country, str) | ||
self.assertIsInstance(project.type, str) | ||
self.assertIsInstance(project.developer, str) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no test for verifier? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately, that data was too sparsely populated to make for a reliable test. To be revised when we can improve test strategies for SDKs. |
||
self.assertTrue(isinstance(project.photos, list)) | ||
|
||
def test_retrieve_biomass_projects(self): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those were too brittle and failing. Proposing to keep tests dumb in the SDKs