Skip to content

Build and test the Python SDK without having to install Python #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2021
Merged

Build and test the Python SDK without having to install Python #44

merged 2 commits into from
Nov 9, 2021

Conversation

pcothenet
Copy link
Contributor

Asana task: https://app.asana.com/0/0/1201348859844393/f

What

  • Use a multi-stage docker file (based on Python) to run the different steps of the build

Why

  • Avoids needing to install every language to be able to publish SDKs

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested review from alianam and kleinjm November 9, 2021 20:28
@alianam alianam mentioned this pull request Nov 9, 2021
Merged
5 tasks
alianam
alianam approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@alianam alianam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for getting this set up for me! I very much appreciate it

@pcothenet pcothenet merged commit 13f1434 into main Nov 9, 2021
@pcothenet pcothenet deleted the pc/docker branch November 9, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alianam alianam alianam approved these changes

@kleinjm kleinjm Awaiting requested review from kleinjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcothenet @alianam