Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to more recent version of pre-commit-hooks #46

Merged
merged 8 commits into from
Nov 11, 2021
Merged

Conversation

pcothenet
Copy link
Contributor

What

  • I noticed we were using a deprecated version of the flake8 precommit hook. Updating it to the now recommend form.

Why

  • Stay current

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested review from alianam and kleinjm November 9, 2021 22:45
Copy link
Contributor

@alianam alianam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@kleinjm kleinjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even realize we had pre-commit on this repo. My executable seems to be referencing the ruby gem version of pre-commit even though I have all the pip packages satisfied. Will need to look into how to keep those packages from interfering

➜  patch-python main ✓ which pre-commit
/Users/jklein/.rbenv/shims/pre-commit

@pcothenet
Copy link
Contributor Author

I didn't even realize we had pre-commit on this repo. My executable seems to be referencing the ruby gem version of pre-commit even though I have all the pip packages satisfied. Will need to look into how to keep those packages from interfering

➜  patch-python main ✓ which pre-commit
/Users/jklein/.rbenv/shims/pre-commit

Yeah, I realized it wasn't actually running on my computer until now. We had the same flaw with Brendan not having yarn install on the main app. I'm wondering if there's a way around this?

@pcothenet pcothenet merged commit 0310e25 into main Nov 11, 2021
@pcothenet pcothenet deleted the pc/precommit branch November 11, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants