Skip to content

Update README links and remove deprecated preferences modules #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2022
Merged

Update README links and remove deprecated preferences modules #51

merged 3 commits into from
Feb 2, 2022

Conversation

zskyfly
Copy link
Contributor

@zskyfly zskyfly commented Feb 2, 2022

What

Just reading through the python client lib and noticed a few small issues.

  • update broken API reference links in the readme
  • remove deprecated preferences modules (need to make this change in your generation code)

Why

** CHANGEME: Why are these changes needed? **

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet
Copy link
Contributor

pcothenet commented Feb 2, 2022 •
edited
Loading

Thanks Zach and good call on the generator ;-) I forgot that removed endpoints need to be removed manually.

@pcothenet pcothenet merged commit d785803 into patch-technology:main Feb 2, 2022
@pcothenet pcothenet mentioned this pull request Feb 2, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcothenet pcothenet pcothenet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zskyfly @pcothenet