Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate issued_to to refactored swagger #68

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Migrate issued_to to refactored swagger #68

merged 1 commit into from
Jul 29, 2022

Conversation

pcothenet
Copy link
Contributor

@pcothenet pcothenet commented Jul 29, 2022 •
edited
Loading

What

  • Slight re-org of the issued_to model after reorganization of the swagger file

Why

  • Reuse schema definitions in swagger => reuse models in the SDK

Notes

  • No functionality change

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested a review from a team July 29, 2022 21:08
@pcothenet pcothenet merged commit 1f6802f into main Jul 29, 2022
@pcothenet pcothenet deleted the pc/issued_to branch July 29, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleinjm kleinjm kleinjm approved these changes

Assignees

@kleinjm kleinjm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcothenet @kleinjm