Skip to content

Remove /estimates/ecommerce endpoint calls #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pin the version of black being used
  • Loading branch information
pcothenet committed Apr 29, 2025

Verified

This commit was signed with the committer’s verified signature.
pcothenet Paul Cothenet
commit 1f6caec47909386baf0821eeacaf112e33df81c5
Binary file added .DS_Store
Binary file not shown.
6 changes: 4 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -12,7 +12,9 @@ jobs:
- uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2.7.0
- uses: actions/setup-python@e9aba2c848f5ebd159c070c61ea2c4e2b122355e # v2.3.4
- uses: psf/black@stable

with:
version: "24.10.0"
Comment on lines +15 to +16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were getting some issues due to inconsistent versions of black.


build-and-test:
# 03/27/23: it looks like there are issues with the tarballs for all python 3.6 versions
# that are on ubuntu-22.04 (ubuntu-latest at the time). To maintain python compatibility
@@ -29,7 +31,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@e9aba2c848f5ebd159c070c61ea2c4e2b122355e # v2.3.4
with:
python-version: '3.6'
python-version: "3.6"

- name: Run tests
env:
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -12,6 +12,6 @@ repos:
- id: flake8
args: ["--config=.flake8"]
- repo: https://github.com/psf/black
rev: 24.10.0
rev: 24.4.2
hooks:
- id: black
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ FROM python:3.8.6 AS base

FROM base AS lint

RUN pip install black
RUN pip install black==24.4.2

WORKDIR /data
ENTRYPOINT ["black"]
@@ -24,9 +24,9 @@ ENTRYPOINT [ "python", "setup.py", "install" ]

FROM dependencies as test

COPY test-requirements.txt .
COPY test-requirements.txt .
RUN pip install -r test-requirements.txt

COPY . .

ENTRYPOINT ["python", "-m", "unittest", "discover", "test/"]
ENTRYPOINT ["python", "-m", "unittest", "discover", "test/"]